-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update printer-creality-ender5-2019.cfg to add instructions for silent boards #6326
Conversation
…t board Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works.
Thankyou for submitting a change, to submit a valid PR please refer to point 3 in the "what to expect" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and add a signed-off-by line. Thanks |
Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works. Tested all endstops, motors, and heaters. Signed-off-by: Jake Aronleigh [email protected]
Added a new commit with that signoff message. Let me know if there's any other issues. Thanks, |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
@JamesH1978 - did you have any further comments on this PR? -Kevin |
Look mainly informational to me, which is fine, i will review Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant see an issue, seems mostly informational for those with a slightly different board.
Thanks
James
Thanks. -Kevin |
…or silent boards (Klipper3d#6326) Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works. Tested all endstops, motors, and heaters. Signed-off-by: Jake Aronleigh <[email protected]>
…or silent boards (#6326) Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works. Tested all endstops, motors, and heaters. Signed-off-by: Jake Aronleigh <[email protected]>
Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works.