Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update printer-creality-ender5-2019.cfg to add instructions for silent boards #6326

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

GhostDog98
Copy link
Contributor

Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works.

…t board

Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works.
@JamesH1978
Copy link
Collaborator

Thankyou for submitting a change, to submit a valid PR please refer to point 3 in the "what to expect" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and add a signed-off-by line.

Thanks
James

Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works. Tested all endstops, motors, and heaters. 

Signed-off-by: Jake Aronleigh [email protected]
@GhostDog98
Copy link
Contributor Author

Thankyou for submitting a change, to submit a valid PR please refer to point 3 in the "what to expect" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and add a signed-off-by line.

Thanks James

Added a new commit with that signoff message. Let me know if there's any other issues.

Thanks,
GhostOverFlow

@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions
Copy link

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Sep 29, 2023
@KevinOConnor
Copy link
Collaborator

@JamesH1978 - did you have any further comments on this PR?

-Kevin

@JamesH1978
Copy link
Collaborator

Look mainly informational to me, which is fine, i will review

Thanks
James

Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant see an issue, seems mostly informational for those with a slightly different board.

Thanks
James

@KevinOConnor KevinOConnor reopened this Oct 9, 2023
@KevinOConnor KevinOConnor merged commit 7eabf02 into Klipper3d:master Oct 9, 2023
1 check failed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

voidtrance pushed a commit to voidtrance/klipper that referenced this pull request Nov 4, 2023
…or silent boards (Klipper3d#6326)

Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works. Tested all endstops, motors, and heaters. 

Signed-off-by: Jake Aronleigh <[email protected]>
rogerlz referenced this pull request in KalicoCrew/kalico Dec 19, 2023
…or silent boards (#6326)

Recently tested on my ender 5 pro that came from creality with a v1.1.5 board. Works. Tested all endstops, motors, and heaters. 

Signed-off-by: Jake Aronleigh <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants